Add benchmarks for specialization #9752
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
suggested changes
Sep 10, 2020
bench-run/src/main/scala/dotty/tools/benchmarks/specialization/Functions.scala
Outdated
Show resolved
Hide resolved
bench-run/src/main/scala/dotty/tools/benchmarks/specialization/Functions.scala
Outdated
Show resolved
Hide resolved
bench-run/src/main/scala/dotty/tools/benchmarks/specialization/Functions.scala
Outdated
Show resolved
Hide resolved
…/Functions.scala Co-authored-by: Nicolas Stucki <[email protected]>
…/Functions.scala Co-authored-by: Nicolas Stucki <[email protected]>
liufengyun
force-pushed
the
add-spec-bench
branch
from
82d8be6 to
cdc14b0
Compare
liufengyun
commented
Sep 11, 2020
| // remove it will result in 200x speed up | ||
| arrByName(1) = null | ||
| arrByName(0).foo(6) | ||
| } |
There was a problem hiding this comment.
It turns out we also need this turnaround to defeat JVM optimization.
nicolasstucki
approved these changes
Sep 11, 2020
nicolasstucki
approved these changes
Sep 11, 2020
liufengyun
force-pushed
the
add-spec-bench
branch
from
8502ffb to
62339a0
Compare
smarter
reviewed
Sep 12, 2020
| inline def times(inline work: Int): Int = { | ||
| var res = 0 | ||
| var count = 0 | ||
| while count < x do |
There was a problem hiding this comment.
I haven't checked what is being done here exactly but note that it's not recommended to use loops when benchmarking on the JVM: http://tutorials.jenkov.com/java-performance/jmh.html#writing-good-benchmarks, instead let JMH run things as many times as needed to get good statistics
There was a problem hiding this comment.
Thanks for the reminder, @smarter . It's really subtle to defeat optimization in microbenchmarks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add benchmarks for specialization